Skip to content

Commit

Permalink
Merge pull request #819 from manifoldco/add-safty-check-to-mutation-o…
Browse files Browse the repository at this point in the history
…bserver

Add additional safety check for mutation observer
  • Loading branch information
Terry Smith authored Jan 8, 2020
2 parents 0fb5d19 + a727ac2 commit e96b816
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,14 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
### Added

- Support for configurable features in plan selector.
- Added safety check for MutationObserver when initializing UI.

## [0.9.0]

### Removed
- `resourceLabel` prop on `<manifold-data-product-logo>` component (previously deprecated in favor of `<manifold-data-resource-logo>`).

- `resourceLabel` prop on `<manifold-data-product-logo>` component (previously deprecated in favor
of `<manifold-data-resource-logo>`).
- `manifold-service-card` component (previously deprecated in favor of `manifold-product-card`).

## [0.8.0]
Expand All @@ -26,7 +29,8 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
### Fixed

- Screenshots now display full images (uncropped). (#751)
- `manifold-data-rename-button` success message now contains the returned updated label value as opposed to the submitted label value. (#756)
- `manifold-data-rename-button` success message now contains the returned updated label value as
opposed to the submitted label value. (#756)

### Changed

Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -125,5 +125,8 @@
"testcafe": "^1.5.0",
"wait-on": "^3.3.0",
"webpack": "^4.41.2"
},
"engines": {
"node": "12.13.x"
}
}
2 changes: 1 addition & 1 deletion src/global/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function mutationCallback(mutationsList: MutationRecord[]) {
mutationsList
.filter(mutation => mutation.type === 'childList')
.forEach(mutation => {
if (mutation.addedNodes) {
if (Array.isArray(mutation.addedNodes) && mutation.addedNodes.length > 1) {
mutation.addedNodes.forEach((node: HTMLElement) => {
if (node.tagName && node.tagName.startsWith('MANIFOLD-')) {
mark(node, 'load');
Expand Down

1 comment on commit e96b816

@vercel
Copy link

@vercel vercel bot commented on e96b816 Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.