add withdraw to frame lazy claim because we have to remove excess funds

manifoldxyz · Jan 31, 2024 · 0c972f1 · 0c972f1
1 parent 7d0d644
commit 0c972f1
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/packages/manifold/contracts/frameclaims/FrameLazyClaim.sol b/packages/manifold/contracts/frameclaims/FrameLazyClaim.sol
@@ -38,6 +38,15 @@ abstract contract FrameLazyClaim is IFrameLazyClaim, AdminControl {
         _transferOwnership(initialOwner);
     }
 
+
+    /**
+     * See {IFrameLazyClaim-withdraw}.
+     */
+    function withdraw(address payable receiver, uint256 amount) external override adminRequired {
+        (bool sent, ) = receiver.call{value: amount}("");
+        if (!sent) revert FailedToTransfer();
+    }
+
     /**
      * See {IFrameLazyClaim-setSigner}.
      */

diff --git a/packages/manifold/contracts/frameclaims/IFrameLazyClaim.sol b/packages/manifold/contracts/frameclaims/IFrameLazyClaim.sol
@@ -11,6 +11,7 @@ interface IFrameLazyClaim {
     enum StorageProtocol { INVALID, NONE, ARWEAVE, IPFS }
 
     error InvalidSignature();
+    error FailedToTransfer();
 
     event FrameClaimInitialized(address indexed creatorContract, uint256 indexed instanceId, address initializer);
     event FrameClaimUpdated(address indexed creatorContract, uint256 indexed instanceId);
@@ -21,6 +22,11 @@ interface IFrameLazyClaim {
         uint256 amount;
     }
 
+    /**
+     * @notice Withdraw funds
+     */
+    function withdraw(address payable receiver, uint256 amount) external;
+
     /**
      * @notice Set the signing address
      * @param signer    the signer address

diff --git a/packages/manifold/test/frameclaims/ERC1155FrameLazyClaim.t.sol b/packages/manifold/test/frameclaims/ERC1155FrameLazyClaim.t.sol
@@ -33,10 +33,16 @@ contract ERC1155FrameLazyClaimTest is Test {
     vm.deal(creator, 10 ether);
     vm.deal(other, 10 ether);
     vm.deal(signer, 10 ether);
+    vm.deal(address(example), 10 ether);
   }
 
   function testAccess() public {
     vm.startPrank(other);
+
+    // Must be admin
+    vm.expectRevert();
+    example.withdraw(payable(other), 20);
+
     // Must be admin
     vm.expectRevert();
     example.setSigner(other);
@@ -76,6 +82,12 @@ contract ERC1155FrameLazyClaimTest is Test {
     vm.stopPrank();
   }
 
+  function testWithdraw() public {
+    vm.startPrank(owner);
+    example.withdraw(payable(owner), 1 ether);
+    vm.stopPrank();
+  }
+
   function testinitializeClaimSanitization() public {
     vm.startPrank(creator);