-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zap): Update runs-on to ubuntu-22.04, Add retry mechanism, Modify run-ci command, Remove --wait flag #88
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d474a43
fix: ZAP URL testing
manoelhc 4ffc06f
fix: install docker compose
manoelhc 7975e53
fix: add sudo
manoelhc 61998bd
fix: remove docker.io installation
manoelhc 5ceafc3
fix: install docker-compose-v2
manoelhc b00abc7
test: new ubuntu version
manoelhc ae46be1
fix: install docker-compose
manoelhc b14246f
test: install docker-compose-v2
manoelhc 46f3bd9
fix: change the way to check the app's health
manoelhc 384120f
fix: remove the --wait flag
manoelhc 9de9939
fix: another attempt of checking the apps
manoelhc 4be1c48
test: another approach
manoelhc 6a0956d
test: another attempt
manoelhc c02c1a9
test: fix url to check
manoelhc 7fde112
fix: protocol
manoelhc adf8fb0
test: another attempt
manoelhc a4b7d47
test: add insecure certs to curl
manoelhc dc81889
fix: clean the code
manoelhc a96772e
fix: add --retry-connrefused
manoelhc cfa2159
fix: final commit
manoelhc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Removal of '--wait' flag might cause race conditions
The '--wait' flag ensures that the services are fully started before proceeding. Removing this flag might cause race conditions where subsequent steps run before the services are ready. Consider re-adding the '--wait' flag or implementing an alternative waiting mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github's docker-compose doesn't support
--wait
flag.