Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{#179|BUG FIX}: fix for ipython>8.17.0 #180

Merged
merged 3 commits into from
Jun 16, 2024

Conversation

guigoruiz1
Copy link
Contributor

Description of new feature, or changes

Corrects the clean_up function call to account for the argument now passed by ipython

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature
  • (Not a feature)
  • All tests are passing

Related Issues and Discussions

Fixes #179

People to notify

@manrajgrover

Copy link
Owner

@manrajgrover manrajgrover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guigoruiz1 My sincere apologies for the delay and really thank you for fixing this.

LGTM! Merging

@manrajgrover manrajgrover merged commit b76fa94 into manrajgrover:master Jun 16, 2024
0 of 12 checks passed
@galenhwang
Copy link

@manrajgrover will there be a new halo release for this fix? the latest release still shows 2020:

https://pypi.org/project/halo/#history

Screenshot 2024-09-03 at 1 17 56 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Halo.__init__.<locals>.clean_up() takes 0 positional arguments but 1 was given
3 participants