Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turnstile icon #537

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

turnstile icon #537

wants to merge 4 commits into from

Conversation

willymaps
Copy link
Contributor

@willymaps willymaps commented Apr 12, 2021

Description of change

Adding a turnstile icon

Link to demonstration

LINK


Closes #493 .

For author

  • Cite changes under the HEAD tag in CHANGELOG.md
  • PR contains only one 15x15 icon
  • Changes fall in accordance to the Maki guidelines
    • Icon geometry is aligned to the pixel grid
    • Icon stays within a 2px trim area
    • Icon uses common geometric building blocks used throughout Maki
    • Icon corners are rounded in either full or half pixel increments
    • Any strokes use 1px
  • Upload the new icon to the Maki icon editor
    • Compare with existing icons
    • Test that stroke/backgrounds/padding work visually

For reviewer

  • Review the interactive map provided to confirm legibility and harmony with existing icons
  • Review each icon variation in an editor, turn on grids and outlines and confirm pixel alignment is maintained to the nearest or half pixel
  • Confirm file requirements stated in Maki guidelines are met
  • Confirm all other changes fall in accordance to the Maki guidelines

@tristen
Copy link
Member

tristen commented Apr 12, 2021

Turnstiles are tricky! It wasn’t immediately clear to me what I was looking at on the map. So just throwing out a quick thought:

The design of turnstiles are not universal and I wonder if an icon that isn’t an accurate visual representation of the thing in real life confusing. Is there a way to illustrate this in a way that accommodates all turnstiles? Like a stacked enter/exit or allowed/not allowed symbols?

@willymaps
Copy link
Contributor Author

Thanks for the thoughtful feedback @tristen. Will give it another go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants