Example Update with XCFrameworks #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support M1 based development and remove the need for Carthage workaround we must migrate to XCFrameworks.
It runs Carthage from the library user point of view and verifies that it can be built successfully.
Xcode 11 no longer supported with the previous changes because you need Xcode 12 so that Carthage can build the project.
1ec5
approved these changes
Jun 3, 2021
| @@ -22,8 +18,8 @@ | |||
| <rect key="frame" x="0.0" y="0.0" width="375" height="667"/> | |||
| <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/> | |||
| <subviews> | |||
| <label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="View route steps in the console." textAlignment="center" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" minimumFontSize="9" translatesAutoresizingMaskIntoConstraints="NO" id="obG-Y5-kRd"> | |||
| <rect key="frame" x="20" y="626.5" width="335" height="21"/> | |||
| <label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="View route steps." textAlignment="center" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" minimumFontSize="9" translatesAutoresizingMaskIntoConstraints="NO" id="obG-Y5-kRd"> | |||
There was a problem hiding this comment.
This storyboard apparently still works, but if you’re interested, we could simplify the project even further by specifying the UILaunchScreen Info.plist key instead of providing a launch screen storyboard.
Co-authored-by: Minh Nguyễn <mxn@1ec5.org>
This was referenced Jun 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #523
Main commits are:
Screenshot from the Example app:
