Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable library code signing #447

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

tyrauber
Copy link
Sponsor Collaborator

@tyrauber tyrauber commented Sep 18, 2024

Description

Fixes #442, XCode Archive : MapLibre.xcframework-ios.signature” couldn’t be copied to “Signatures” because an item with the same name already exists

Library code signing causes issue for both react-native and expo usage. In the past we had a build phase in the expo plugin to remove the *.signature file, but that was wed to xCode 15. Now with 16., the plugin doesn't work. Additionally, for react-native apps the developer must personally remove the *.signature.

It's a pain in the ass. Let's just disable code signing of the library and call it a day.

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I formatted JS and TS files with running yarn lint:fix in the root folder
  • I have run tests via yarn test in the root folder
  • I updated the documentation with running yarn generate in the root folder
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/updated a sample (/example)

@tyrauber tyrauber merged commit 2125a6d into maplibre:main Sep 18, 2024
4 checks passed
@tyrauber tyrauber deleted the fix/disable-code-signing branch September 18, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant