Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename resources indicators #71

Merged
merged 15 commits into from
Aug 1, 2022
Merged

Rename resources indicators #71

merged 15 commits into from
Aug 1, 2022

Conversation

goergen95
Copy link
Member

No description provided.

@goergen95 goergen95 linked an issue May 28, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #71 (ba506a7) into main (926fceb) will increase coverage by 0.97%.
The diff coverage is 90.03%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   80.63%   81.60%   +0.97%     
==========================================
  Files          36       36              
  Lines        2473     2474       +1     
==========================================
+ Hits         1994     2019      +25     
+ Misses        479      455      -24     
Impacted Files Coverage Δ
R/get_gfw_emissions.R 100.00% <ø> (ø)
R/get_gfw_lossyear.R 66.66% <ø> (ø)
R/get_gfw_treecover.R 93.33% <ø> (ø)
R/get_gmw.R 23.63% <0.00%> (ø)
R/get_nasa_srtm.R 55.17% <ø> (ø)
R/get_worldclim.R 47.50% <ø> (ø)
R/calc_biome.R 95.00% <50.00%> (ø)
R/get_nelson_et_al.R 50.00% <50.00%> (ø)
R/calc_precipitation_chirps.R 72.80% <73.68%> (ø)
R/calc_elevation.R 89.02% <80.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926fceb...ba506a7. Read the comment docs.

@goergen95
Copy link
Member Author

Checks out fine now except the check on upstream packages. Let me investigate and have a proper review before merging.

@goergen95
Copy link
Member Author

Checks are passing now. We could merge to main, I would suggest under version 0.2.0, because there are substantial changes to both public and private API. So after the merge I would quickly sent the package off to CRAN. I am thinking about a good timing for this since we already have sent an updated version to CRAN earlier this month... Is there anything else (like new indicators/resources) you are currently working on that we should wait for before merging?

@Ohm-Np
Copy link
Contributor

Ohm-Np commented Jul 27, 2022

May be we could add at least one another resource - fire occurence/burned area before next release. We have not decided yet which data source should we go with for this resource. For FIRMS, I have advanced a bit with the scripts but for MODIS burned area, it requires the use of Earthdata Login account and I haven't progressed much on establishing the connection using login credentials.

And as discussed earlier, should we include the workflows in technical details section like this diagram here? I have prepared similar diagrams for other indicators too, if it makes sense to include these in vignettes. If so, I could start writing this section and you could review and update the document.

@Ohm-Np
Copy link
Contributor

Ohm-Np commented Aug 1, 2022

@goergen95 we should may be merge this pull request, I will work on new branch for fire events and then push the changes from my side.

@goergen95 goergen95 merged commit 23f0f41 into main Aug 1, 2022
@goergen95 goergen95 deleted the rename_resources-indicators branch June 13, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename resources and indicators
3 participants