-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename resources indicators #71
Conversation
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 80.63% 81.60% +0.97%
==========================================
Files 36 36
Lines 2473 2474 +1
==========================================
+ Hits 1994 2019 +25
+ Misses 479 455 -24
Continue to review full report at Codecov.
|
Merge branch 'main' into rename_resources-indicators # Conflicts: # R/calc_biome.R # R/calc_ecoregion.R # tests/testthat/test-portfolio.R
Checks out fine now except the check on upstream packages. Let me investigate and have a proper review before merging. |
Checks are passing now. We could merge to main, I would suggest under version 0.2.0, because there are substantial changes to both public and private API. So after the merge I would quickly sent the package off to CRAN. I am thinking about a good timing for this since we already have sent an updated version to CRAN earlier this month... Is there anything else (like new indicators/resources) you are currently working on that we should wait for before merging? |
May be we could add at least one another resource - fire occurence/burned area before next release. We have not decided yet which data source should we go with for this resource. For FIRMS, I have advanced a bit with the scripts but for MODIS burned area, it requires the use of Earthdata Login account and I haven't progressed much on establishing the connection using login credentials. And as discussed earlier, should we include the workflows in technical details section like this diagram here? I have prepared similar diagrams for other indicators too, if it makes sense to include these in vignettes. If so, I could start writing this section and you could review and update the document. |
@goergen95 we should may be merge this pull request, I will work on new branch for fire events and then push the changes from my side. |
No description provided.