add global column to challenges and implement filtering for the column #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollinBeczak
force-pushed
the
add-is_global-column-to-challenges
branch
from
8ec0d01
to
6da8363
Compare
ljdelight
reviewed
Sep 3, 2024
CollinBeczak
force-pushed
the
add-is_global-column-to-challenges
branch
from
4ce8b96
to
b6e8a65
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Frontend: maproulette/maproulette3#2382
Resolves: maproulette/maproulette3#2373 & maproulette/maproulette3#2350
This PR adds support for a new column in the challenges table called is_global. The challenges.is_global column represents if a challenge is classified as global, currently a challenge is classified as global if it is wider than 180 degrees (half the maps width) or taller than 90 degrees (half the maps height).
A new .sql file was added to update the global column for challenges that currently exist. This column will also be set when a challenge is created or enters a ready status.