add users.avatar_url constraint and default #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljdelight
requested changes
Aug 13, 2024
There was a problem hiding this comment.
I see unintentional changes to Groups and other objects, so I think we should remove about all of the scala changes related to the avatar_url db requirement changes. For example, it's fine to update user.avatar_url parsers but no changes should be done for group.avatar_url (which looks to always be null).
CollinBeczak
force-pushed
the
collinBeczak/add-avatar_url-contraint-and-default
branch
from
b6b5066
to
622f9af
Compare
|
ljdelight
deleted the
collinBeczak/add-avatar_url-contraint-and-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved conversation from #1137
Resolves issue: Resolves: maproulette/maproulette3#2205
This pr adds a new migration file that sets the default of the users.avatar_url column to '/assets/images/user_no_image.png', and prevents its value from being null. This change made it so that avatar_url was no longer an option, so tests and parserss were updated accordingly.