Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile instructions widget error #2074

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

CollinBeczak
Copy link
Collaborator

Issue: There was an undefined prop called workspaceContext in the useMRProperties function. This undefined prop being called would freeze the user interface. In these cases where this prop is not provided, an empty object will be passed to prevent the interface from crashing.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #2074 (2e69b94) into develop (d2d0792) will decrease coverage by 0.04%.
Report is 2 commits behind head on develop.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #2074      +/-   ##
===========================================
- Coverage    25.05%   25.01%   -0.04%     
===========================================
  Files          635      638       +3     
  Lines        21489    21608     +119     
  Branches      6532     6572      +40     
===========================================
+ Hits          5383     5406      +23     
- Misses       13502    13577      +75     
- Partials      2604     2625      +21     
Files Changed Coverage Δ
src/hooks/UseMRProperties/UseMRProperties.js 3.57% <0.00%> (-0.28%) ⬇️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AndrewPhilbin AndrewPhilbin merged commit 1bf75ea into develop Sep 1, 2023
3 checks passed
@jschwarz2030 jschwarz2030 deleted the mobileInstructionsErrorFix branch October 18, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants