Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous cleanup #2477

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Miscellaneous cleanup #2477

merged 4 commits into from
Oct 28, 2024

Conversation

jake-low
Copy link
Contributor

  • Remove an unused component (HomePane, a leftover piece of an old version of the homepage) and move a translation string from that namespace that was used on the homepage to the Home namespace. Delete the other translation strings which were only used by HomePane
  • Remove the REACT_APP_VERSION_SEMVER env var which was magically populated at build time, and instead retrieve the version number in JS by importing the project's package.json which is the more typical pattern for this in my experience.
  • Remove service worker code that was not in use (thankfully - service workers, especially caching SWs, are super footgunny and really frustrating to debug).

@jake-low jake-low merged commit 8b79d75 into main Oct 28, 2024
6 checks passed
@jake-low jake-low deleted the jlow/misc-cleanup branch October 28, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants