E2E BASE: Test for Results, Completeness Project and others #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rup-Narayan-Rajbanshi
force-pushed
the
feature/e2e-result-firebase
branch
from
d5ce802 to
67e2377
Compare
Rup-Narayan-Rajbanshi
changed the title
Rup-Narayan-Rajbanshi
force-pushed
the
feature/e2e-result-firebase
branch
from
67e2377 to
be80c0c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #168 +/- ##
===========================================
+ Coverage 80.48% 81.24% +0.75%
===========================================
Files 196 196
Lines 10667 10747 +80
Branches 951 949 -2
===========================================
+ Hits 8585 8731 +146
+ Misses 1761 1683 -78
- Partials 321 333 +12 ☔ View full report in Codecov by Sentry. |
Rup-Narayan-Rajbanshi
force-pushed
the
feature/e2e-result-firebase
branch
2 times, most recently
from
a634f80 to
6d8aaae
Compare
Rup-Narayan-Rajbanshi
changed the title
Rup-Narayan-Rajbanshi
force-pushed
the
feature/e2e-result-firebase
branch
2 times, most recently
from
8c0ae79 to
3ae7541
Compare
susilnem
requested changes
Sep 18, 2025
| ) | ||
|
|
||
| # Test push tasks results to firebase | ||
| contributor_user_groups = ContributorUserGroupFactory.create_batch(2, **self.user_resource_kwargs) |
Member
There was a problem hiding this comment.
Let's create this from the assets as we already have the mutation for the contributor_user_groups.
"create_contributor_user_group_data_list": [
{
"clientId": "01K49J0QPCZM2JCNC9AEE6HT8Y",,
"name": "User Group 01",
"description": "A user group for contributor user 01",
},
{
"clientId": "01K49J0QPCZM2JCNC9AEE6HT8R",,
"name": "User Group 01",
"description": "A user group for contributor user 01",
}
],
| # Replace userGroups | ||
| group_value[new_key]["userGroups"] = user_groups_input | ||
|
|
||
| ref_results = Config.FIREBASE_HELPER.ref(Config.FirebaseKeys.results_projects()) |
Member
There was a problem hiding this comment.
Suggested change
| ref_results = Config.FIREBASE_HELPER.ref(Config.FirebaseKeys.results_projects()) | |
| ref_results = Config.FIREBASE_HELPER.ref(f"/v2/results/{project_id}/") |
Collaborator
There was a problem hiding this comment.
For e2e tests, you can directly specific the URLs
It helps to identify breaking changes.
| "app_version": mapping_session.app_version, | ||
| "start_time": mapping_session.start_time.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z", | ||
| "end_time": mapping_session.end_time.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z", | ||
| "results_count": MappingSessionResult.objects.count(), |
Member
There was a problem hiding this comment.
Add other checks too!
Suggested change
| "results_count": MappingSessionResult.objects.count(), | |
| "mapping_session_count": MappingSession.objects.count(), | |
| "results_count": MappingSessionResult.objects.count(), | |
| "user_groups_count": MappingSessionUserGroup.objects.count(), | |
| MappingSessionResultTemp.objects.count(), | ||
| ] != [0, 0, 0, 0, 0] | ||
|
|
||
| mapping_session = MappingSession.objects.first() |
Member
There was a problem hiding this comment.
Add a todo we need to find another way to check this!
|
|
||
| expected_pulled_results_data = test_data["expected_pulled_results_data"] | ||
| expected_pulled_results_data["project_firebase_id"] = next(iter(fb_results_data)) | ||
| assert pull_firebase_data == expected_pulled_results_data |
Member
There was a problem hiding this comment.
Suggested change
| assert pull_firebase_data == expected_pulled_results_data | |
| assert pull_firebase_data == expected_pulled_results_data, "Difference found for pulled results data." | |
|
|
||
| user_groups_input = {str(ug.firebase_id): True for ug in contributor_user_groups} | ||
|
|
||
| for group_key, group_value in input_data[project_fb_id].items(): # noqa: B007 |
Member
There was a problem hiding this comment.
Suggested change
| for group_key, group_value in input_data[project_fb_id].items(): # noqa: B007 | |
| for _, group_value in input_data[project_fb_id].items(): |
| assert mapping_session.end_time is not None | ||
|
|
||
| pull_firebase_data = { | ||
| "project_firebase_id": mapping_session.project_task_group.project.firebase_id, |
Member
There was a problem hiding this comment.
Suggested change
| "project_firebase_id": mapping_session.project_task_group.project.firebase_id, |
| } | ||
|
|
||
| expected_pulled_results_data = test_data["expected_pulled_results_data"] | ||
| expected_pulled_results_data["project_firebase_id"] = next(iter(fb_results_data)) |
Member
There was a problem hiding this comment.
Suggested change
| expected_pulled_results_data["project_firebase_id"] = next(iter(fb_results_data)) |
| MappingSessionUserGroup.objects.count(), | ||
| MappingSessionUserGroupTemp.objects.count(), | ||
| MappingSessionResultTemp.objects.count(), | ||
| ] == [0, 0, 0, 0, 0] |
Member
There was a problem hiding this comment.
Suggested change
| ] == [0, 0, 0, 0, 0] | |
| ] == [0, 0, 0, 0, 0], "Mapping session data should be empty before pull from firebase" | |
| MappingSessionUserGroup.objects.count(), | ||
| MappingSessionUserGroupTemp.objects.count(), | ||
| MappingSessionResultTemp.objects.count(), | ||
| ] != [0, 0, 0, 0, 0] |
Member
There was a problem hiding this comment.
Suggested change
| ] != [0, 0, 0, 0, 0] | |
| ] != [0, 0, 0, 0, 0], "Mapping session data should not be empty after pull from firebase" | |
Rup-Narayan-Rajbanshi
force-pushed
the
feature/e2e-result-firebase
branch
8 times, most recently
from
cd05e8f to
36e4124
Compare
Rup-Narayan-Rajbanshi
changed the title
Rup-Narayan-Rajbanshi
changed the title
Rup-Narayan-Rajbanshi
force-pushed
the
feature/e2e-result-firebase
branch
from
0196784 to
711d3d1
Compare
tnagorra
requested changes
Sep 24, 2025
| ) | ||
|
|
||
| # Test push tasks results to firebase | ||
| # Creating ContributorUserGroup: Without authentication |
Collaborator
There was a problem hiding this comment.
Is this without authentication?
Collaborator
|
@Rup-Narayan-Rajbanshi Please add related PRs |
tnagorra
changed the title
tnagorra
changed the title
Rup-Narayan-Rajbanshi
force-pushed
the
feature/e2e-result-firebase
branch
3 times, most recently
from
f0adf69 to
14c3727
Compare
- remove un-necessary publish tutorial step
tnagorra
force-pushed
the
feature/e2e-result-firebase
branch
from
14c3727 to
8ff0643
Compare
Collaborator
|
I have fixed the issues in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Depends on
This PR doesn't introduce any:
printThis PR contains valid: