fix: case with special symbols in password #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed a sad misspell in bumpversion config * Added Python 3.10 binary for GitHub actions * Trying to make coveralls work
docs: clarified the documentation fix: type hintings
marazmiki
requested changes
Jan 6, 2022
|
|
||
| master_doc = "index" # It's important for RTFD | ||
| exclude_patterns = [] | ||
| exclude_patterns: list = [] |
There was a problem hiding this comment.
Not sure we need to hint sphinx config :)
| self._dsn = dsn | ||
| self._raw_bits = None | ||
| self._parsed_bits = {} | ||
| self._raw_bits: ParseResult |
There was a problem hiding this comment.
Again, not sure we should type-hint any internals.
| return self.default_region | ||
|
|
||
| def _parse_bucket_name(self) -> str: | ||
| def _parse_bucket_name(self) -> Optional[str]: |
There was a problem hiding this comment.
Perhaps, this shouldn't be an optional one.
| return super()._is_host_given() | ||
|
|
||
| def _parse_bucket_name(self) -> str: | ||
| def _parse_bucket_name(self) -> Optional[str]: |
There was a problem hiding this comment.
Actually, I cannot even imagine the situation, when BUCKET is not presented inside S3 URLs. So, I'm pretty sure, everything related to a bucket should be mandatory rather than optional
marazmiki
force-pushed
the
master
branch
3 times, most recently
from
20eb25e to
c943d86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.