Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Rework #5

Open
wants to merge 12 commits into
base: README_rework
Choose a base branch
from

Conversation

ElectronicsArchiver
Copy link

Please check the Preview.

Changes

  • Added license badge
  • Converted raw links to referenced ones
  • General formatting / spacing
  • Moved resources into Resources folder
  • Moved source code into Source folder
  • Added quicklinks
  • Added video badges

Repository Recommendations

  • Add tags, such as:
    • audio
    • sample-player
    • sequencer
    • arduino
  • Disable unused widgets:
    • Releases
    • Packages
  • Disable unused tabs:
    • Actions
    • Projects
    • Wiki

Copy link
Owner

@marcel-licence marcel-licence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your pull request. I will need some time to go through all details.

I also like to use an updated folder structure but it is not supported by the Arduino IDE. I try to keep the compatibility as high as possible. I got this message when trying to open the project:
grafik

Which IDE did you use?

@ElectronicsArchiver
Copy link
Author

Oh right, the Arduino IDE has that stupid
you have to place the ino file in a folder with the same name
limitation.

Lemme fix that.

@ElectronicsArchiver
Copy link
Author

ElectronicsArchiver commented Apr 10, 2022

Generally speaking I'd use PlatformIO for such a case,
while it also isn't as good as I'd like it to be, at least it
isn't that limited in that respect.

In that regard I'd recommend not using ino files
for your non-main files, considering that they are
just .cpp / .hpp files.

@marcel-licence
Copy link
Owner

I will try to checkout your exact pull request. I am not sure how to do that. In addition to that I need some more time for a review because I also also like to reuse ideas as a general basis for all projects

@ElectronicsArchiver ElectronicsArchiver marked this pull request as draft August 11, 2022 21:12
@marcel-licence marcel-licence changed the base branch from main to README_rework April 21, 2023 14:06
@marcel-licence marcel-licence marked this pull request as ready for review April 21, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants