Skip to content

Conversation

@langpavel
Copy link

@langpavel langpavel commented May 30, 2018

WARNING: You don't want merge this :-)

Please, do not take this seriously, you can checkout my current version which I'm using now.. many of features are disabled
For example I completely drop <FormattedHTMLMessage /> and other apis are not really ideal..
My goal is Translator class which can be used with ease outside of React…
…and I know that I will need TranslatorManager singleton on client which will be feeded automatically by Webpack generated code…
Also note my rewrite of babel-plugin-react-intl (published on npm as @langpavel/babel-plugin-react-intl)

marcesengel and others added 23 commits May 29, 2018 23:22
Support for:
- new Context API
- static getDerivedStateFromProps
createContext() vs. React.createContext() made no difference - I just choose the latter because of personal preference
@langpavel langpavel changed the title Context api and cleanup I'm sharing: Context API and Cleanup, really not ready May 30, 2018
@marcesengel
Copy link
Owner

Hey,
I'd be happy if you'd join us on slack at react-intl.slack.com to get this fork going.
I respect your work 👍, but I think that (in the short- to mid-term) it'll be more realistic to just update the current code instead of completely replacing it. All the test cases are reason enough to me for now... :D

@langpavel
Copy link
Author

Update of current code is wasting by time by my own experience. I tried this.
More clean is keep current API but rewrote all the things, keeping only good pieces of design. (Really not much..)

@jaybe78
Copy link

jaybe78 commented Nov 29, 2018

@DragonRaider5 what is the status on your New Context API branch ? is is ready to use ?
Not sure whether you're still working on this but if you need some help let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants