Skip to content

Conversation

@joelhawksley
Copy link

I would like to propose that we downgrade the default severity of a11y-related rules to warning from error.

While I admire the courage it takes to establish such a strict set of default rules for the linter, I believe we should reserve errors for cases where the HTML is truly invalid and use lower severities for other cases.

The changes here are just an example. If y'all agree with this proposal, I think we should discuss what additional rules need downgraded.

I would like to propose that we downgrade the default severity
of a11y-related rules to `warning` from `error`.

While I admire the courage it takes to establish such a strict
set of default rules for the linter, I worry that we will scare
people away from using Herb with the current approach.

I believe we should reserve errors for cases where the HTML is
truly invalid and use lower severities for other cases.
@marcoroth
Copy link
Owner

In general, I agree with changing the severity of rules 👍🏼

For context: initially, I wanted to have all rules enabled by default, so that these rules get seen, used, and "validated" by as many people as possible. That meant that we also just added all rules to the error severity. Consequently, all rules are probably still "too aggressive" as we haven't balanced the levels yet.

RE: the a11y rules: I wanted to have them enabled by default so people get exposed to these concerns and maybe can even pick up and learn something from the linter. Having the linter give you a little nudge as you write the HTML is good thing. Especially, since a11y is not the first thing most people think about when writing code.

If we would make these rules opt-in way less people will actually use and see them. As accessibility gots more important I think it's fair to say that people should willingly disable the rules if they feel like they get "too annoying". But then it's a conscious decision on their part.

Therefore, I’d rather have these a11y rules report at the info level by default (so they don’t fail the build), than being disabled by default.

@marcoroth marcoroth changed the title Accessibility rules should be warnings, not errors Linter: Accessibility rules should be warnings, not errors Jan 16, 2026
@joelhawksley
Copy link
Author

For context: initially, I wanted to have all rules enabled by default, so that these rules get seen, used, and "validated" by as many people as possible.

I still think this is correct, in that we should run and report all rules by default.

I’d rather have these a11y rules report at the info level by default (so they don’t fail the build), than being disabled by default.

Interesting, I'd have expected warning to behave this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants