Skip to content

Linter: Allow style inside svg for html-head-only-elements #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoroth merged 1 commit into from
Jan 18, 2026
+21 −0
Merged

Linter: Allow style inside svg for html-head-only-elements #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions javascript/packages/linter/src/rules/html-head-only-elements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ class HeadOnlyElementsVisitor extends BaseRuleVisitor {
if (!this.insideBody) return
if (!isHeadOnlyTag(tagName)) return
if (tagName === "title" && this.insideSVG) return
if (tagName === "style" && this.insideSVG) return
if (tagName === "meta" && this.hasItempropAttribute(node)) return

this.addOffense(
Expand Down
20 changes: 20 additions & 0 deletions javascript/packages/linter/test/rules/html-head-only-elements.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,26 @@ describe("html-head-only-elements", () => {
`)
})

test("allows style element inside SVG", () => {
expectNoOffenses(dedent`
<!DOCTYPE html>
<html lang="en">
<head>
<title>Hi</title>
</head>
<body>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 29 29">
<defs>
<style>
.cls-1 {fill:none;stroke:#fff}
</style>
</defs>
</svg>
</body>
</html>
`)
})

test("still fails for other head-only elements inside SVG", () => {
expectError("Element `<meta>` must be placed inside the `<head>` tag.")
expectError("Element `<link>` must be placed inside the `<head>` tag.")
Expand Down
Loading