Engine: Handle trailing comments in ERB output tags #1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where ERB output tags ending with inline Ruby comments caused syntax errors when being compiled.
For example, this template:
Previously compiled to:
The
#starts a comment and will comment out).to_s;which leads to runtime syntax errors. The fix adds a newline before closing parentheses when the code contains#:In the future, we could ideally omit/strip code comments altogether using Prism.
Fixes #964