feat: functions for updating resource permissions and getting associated policies for a permission #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohsinEngineer
requested review from
ryshoooo and
marcospereirampj
as code owners
MohsinEngineer
changed the title
|
All test cases working and code coverage intact. No breaking changes. Would appreciate quick turnaround / feedback. We have to use this functionality in an ongoing project. |
ryshoooo
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
Thanks a lot @MohsinEngineer! This looks great and has been on my todo list for a while! Many thanks! :) The tests are fine as they are
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the functions which were needed to implement resource based access control using Keycloak.
The library lacked the functionality for updating resource permissions and getting associated policies for a given permission.