Skip to content

New feature: Add the max_retries parameter #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

roguh
Copy link
Contributor

@roguh roguh commented Oct 4, 2024

Allow configuring the max_retries parameter for HTTP requests.

This is passed to requests.adapters.HTTPAdapter to allow for more retries.

@roguh roguh force-pushed the add_custom_max_retries branch 2 times, most recently from 15a4fab to 294a860 Compare October 4, 2024 00:19
@roguh roguh changed the title Add the max_retries parameter New feature: Add the max_retries parameter Oct 4, 2024
@roguh roguh force-pushed the add_custom_max_retries branch from 294a860 to 3de521d Compare October 4, 2024 00:33
This is passed to requests.adapters.HTTPAdapter to allow for more retries
@roguh roguh force-pushed the add_custom_max_retries branch from 3de521d to 52add35 Compare October 4, 2024 00:35
@roguh
Copy link
Contributor Author

roguh commented Oct 4, 2024

After a couple force-pushes, I got all the linters and tests to pass.

Thanks for the project! Those are some thorough GHAs :)

@roguh
Copy link
Contributor Author

roguh commented Oct 4, 2024

Is this ok for the changelog?

## Unreleased

### Feat

- Add the max_retries parameter

Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @roguh, LGTM! :)

@ryshoooo ryshoooo merged commit 05c2e7a into marcospereirampj:master Oct 4, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants