Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change httpx proxies argument to mounts #622

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: change httpx proxies argument to mounts #622

merged 1 commit into from
Nov 29, 2024

Conversation

jonthemango
Copy link
Contributor

Due to recent httpx library changes, proxies has been replaced for proxy and mounts.

Changelog for httpx: https://github.com/encode/httpx/blob/master/CHANGELOG.md#0280-28th-november-2024

Docs:

@jonthemango jonthemango mentioned this pull request Nov 28, 2024
Closed
ryshoooo
ryshoooo approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jonthemango! :) LGTM

@ryshoooo ryshoooo merged commit 371d11a into marcospereirampj:master Nov 29, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryshoooo ryshoooo ryshoooo approved these changes

@marcospereirampj marcospereirampj Awaiting requested review from marcospereirampj marcospereirampj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonthemango @ryshoooo