Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed import errors for jQuery version #1112

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Conversation

marekdedic
Copy link
Owner

  • Fixed missing ILBOptions interface
  • Added type decalrations to package.json exports field
  • Split builds of native and jquery versions

Closes #1105

Copy link

relativeci bot commented Oct 5, 2024

imagelightbox-jquery

#153 Bundle Size — 11.59KiB (+983.47%).

d02fd45(current) vs f55e551 master#146(baseline)

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#153
     Baseline
#146
Regression  Initial JS 11.59KiB(+983.47%) 1.07KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 100% 0%
No change  Chunks 1 1
No change  Assets 1 1
Change  Modules 24(+2300%) 1
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#153
     Baseline
#146
Regression  JS 11.59KiB (+983.47%) 1.07KiB

Bundle analysis reportBranch jquery-import-fixesProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

relativeci bot commented Oct 5, 2024

imagelightbox-native

#777 Bundle Size — 10.94KiB (0%).

d02fd45(current) vs f55e551 master#770(baseline)

Bundle metrics  no changes
                 Current
#777
     Baseline
#770
No change  Initial JS 10.94KiB 10.94KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 0% 100%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 23 23
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#777
     Baseline
#770
No change  JS 10.94KiB 10.94KiB

Bundle analysis reportBranch jquery-import-fixesProject dashboard


Generated by RelativeCIDocumentationReport issue

@marekdedic marekdedic merged commit 35503ef into master Oct 5, 2024
14 of 15 checks passed
@marekdedic marekdedic deleted the jquery-import-fixes branch October 5, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jquery import is broken
1 participant