Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only autoplaying videos after they've been fully loaded and transitioned in #1113

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

marekdedic
Copy link
Owner

Closes #941

Copy link

relativeci bot commented Oct 6, 2024

imagelightbox-jquery

#156 Bundle Size — 11.68KiB (+0.79%).

12cf5b4(current) vs 35503ef master#154(baseline)

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#156
     Baseline
#154
Regression  Initial JS 11.68KiB(+0.79%) 11.59KiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 100% 100%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 24 24
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#156
     Baseline
#154
Regression  JS 11.68KiB (+0.79%) 11.59KiB

Bundle analysis reportBranch autoplay-timingProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

relativeci bot commented Oct 6, 2024

imagelightbox-native

#780 Bundle Size — 11.03KiB (+0.84%).

12cf5b4(current) vs 35503ef master#778(baseline)

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#780
     Baseline
#778
Regression  Initial JS 11.03KiB(+0.84%) 10.94KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 100% 0%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 23 23
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#780
     Baseline
#778
Regression  JS 11.03KiB (+0.84%) 10.94KiB

Bundle analysis reportBranch autoplay-timingProject dashboard


Generated by RelativeCIDocumentationReport issue

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11200566870

Details

  • 1 of 12 (8.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 86.168%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/PreloadedVideo.ts 0 1 0.0%
src/lib/VideoCache.ts 0 1 0.0%
src/lib/ImageView.ts 1 10 10.0%
Totals Coverage Status
Change from base Build 11192307931: -0.4%
Covered Lines: 380
Relevant Lines: 441

💛 - Coveralls

@marekdedic marekdedic merged commit 2cfa45b into master Oct 6, 2024
14 of 15 checks passed
@marekdedic marekdedic deleted the autoplay-timing branch October 6, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only autoplay videos after they are fully transitioned in
2 participants