Skip to content

MCOL-5133: Stage2 stand alone cli tool #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

MCOL-5133: Stage2 stand alone cli tool #3388

merged 1 commit into from
Mar 13, 2025

Conversation

mariadb-AlanMologorsky
Copy link
Contributor

  • [fix] client class methods
  • [fix] Transaction management at endpoint handling level
  • [fix] add_node and set_mode methods to use TransactionManager

@mariadb-AlanMologorsky mariadb-AlanMologorsky changed the title MCOL-5133: Stage2 stand alone cli tool [DNM] MCOL-5133: Stage2 stand alone cli tool Jan 24, 2025
drrtuy
drrtuy reviewed Feb 20, 2025
View reviewed changes
drrtuy
drrtuy reviewed Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@drrtuy drrtuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz comment on the question

@mariadb-AlanMologorsky mariadb-AlanMologorsky force-pushed the feature/MCOL-5133-stage2-stand-alone-cli branch from 479f3d2 to 66b212a Compare February 27, 2025 11:48
@mariadb-AlanMologorsky mariadb-AlanMologorsky force-pushed the feature/MCOL-5133-stage2-stand-alone-cli branch from 66b212a to 26b4139 Compare March 7, 2025 00:40
drrtuy
drrtuy approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@drrtuy drrtuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested ACK

@mariadb-AlanMologorsky
feat(cmapi): MCOL-5133: Stage2 stand alone cli tool.
56cd9cd 
[fix] client class methods
[fix] Transaction management at endpoint handling level
[fix] add_node and set_mode methods to use TransactionManager
@mariadb-AlanMologorsky mariadb-AlanMologorsky force-pushed the feature/MCOL-5133-stage2-stand-alone-cli branch from 26b4139 to 56cd9cd Compare March 13, 2025 04:19
@mariadb-AlanMologorsky mariadb-AlanMologorsky merged commit af10cb1 into develop Mar 13, 2025
1 check failed
@mariadb-AlanMologorsky mariadb-AlanMologorsky deleted the feature/MCOL-5133-stage2-stand-alone-cli branch March 13, 2025 04:20
@mariadb-AlanMologorsky mariadb-AlanMologorsky changed the title [DNM] MCOL-5133: Stage2 stand alone cli tool MCOL-5133: Stage2 stand alone cli tool Mar 13, 2025
@mariadb-AlanMologorsky mariadb-AlanMologorsky mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drrtuy drrtuy drrtuy approved these changes

@mariadb-LeonidFedorov mariadb-LeonidFedorov Awaiting requested review from mariadb-LeonidFedorov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariadb-AlanMologorsky @drrtuy