add option to upload dependency layer to S3 first #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariamrf
reviewed
Jan 5, 2021
| echo "Uploading dependencies to S3..." | ||
| aws s3 cp dependencies.zip s3://"${INPUT_S3_BUCKET_NAME}"/dependencies.zip | ||
| echo "Publishing dependencies from S3 as a layer..." | ||
| local result=$(aws lambda publish-layer-version --layer-name "${INPUT_LAMBDA_LAYER_ARN}" --content S3Bucket="${INPUT_S3_BUCKET_NAME}",S3Key=dependencies.zip) |
Owner
There was a problem hiding this comment.
I think the file key on S3 should be either configurable or derived from the lambda layer ARN; if the user has more than one lambda layer they would have to have different buckets for it which is not something we should force imo
| s3_bucket_name: | ||
| description: The S3 bucket name for the dependencies layer upload. | ||
| required: false | ||
| default: no-bucket-name-here |
Owner
There was a problem hiding this comment.
s3_bucket_name is then conditionally required, right? If use_s3 is true s3_bucket_name must be set. If the user does not set it, it will try to upload to no-bucket-name-here. I don't think this should be supported; the error messages might not make sense to the user, and there is a chance, however tiny, that someone owns this bucket.
Possible solutions:
- Remove
use_s3and only keeps3_bucket_namewhich would not have a default and if set, we upload to S3 - Add a conditional in the bash script to not upload to S3 if the
s3_bucket_nameis not explicitly set
Either way I don't think we should have a default value for this. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.