Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify bat file to: #3

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Modify bat file to: #3

wants to merge 11 commits into from

Conversation

zhaogao-git
Copy link

  1. download protobuf-cpp-.zip file using powershell
  2. bakup CMakeLists.txt and override with CMakeLists_minexport in both the root and src folder

emjotde and others added 11 commits October 2, 2018 16:58
@emjotde
add . as include directory
2130954
@anthonyaue
Messy first attempt at getting a usable windows dll. Cleanup to follow.
828d581
@anthonyaue
Beginning of cleanup. Separating changes required for min_export into
e95aca4 
separate files since they don't play nice with the existing bits.
@anthonyaue
Revert files to original
9cb6ebb
@anthonyaue
Fix bad revert
b083126
@anthonyaue
Add some documentation to the new parallel make files
dab0020
@emjotde
Merge branch 'master' into test
78deeaf
@anthonyaue
Merge pull request #1 from marian-nmt/anthonyaue/min_export_dll
b92ee5f 
Add parallel build files to build usable minimal shared sentencepiece dll with MSVC
@emjotde
do not warn about unused vars in generated code
9a94870
@emjotde
Merge branch 'warn'
1a38d26
Modify bat file to:
97481c0 
1. download protobuf-cpp-<version>.zip file using powershell
2. bakup CMakeLists.txt and override with CMakeLists_minexport in both the root and src folder
@emjotde
Copy link
Member

emjotde commented Dec 13, 2018

This one needs to be discussed.

@anthonyaue
Copy link
Collaborator

Can we merge this in? It only affects the windows build, which does not work properly on a stock windows box without the changes.

robberlang pushed a commit to robberlang/sentencepiece that referenced this pull request Aug 17, 2023
@XapaJIaMnu @rjai
@emjotde @snukky @alexandremuzio
Update spm (marian-nmt#3)
acb66f4 
* Adding alternative project name for spm latest to prevent lib conflicts

* Update cmake

* Update CMakeFiles to allow for configurable artifact names

* Enables --encode_unicode_case option for case-aware sentence piece (marian-nmt#10)

* Enables --encode_unicode_case option for case-aware sentence piece
* Example: This IS a TEST OF THE CASING gets converted internally to Tthis Uis a Atest of the casing before segmentation.
* This is fully reversible.

* Enable toggling Case Encoding flag from C++ Train API (marian-nmt#11)

* Enable toggling Case Encoding flag from C++ Train API
* Fixing issue with hardcoding truth value of encode_decode_case flag

* Disable denormalizer flags (marian-nmt#13)

Co-authored-by: Rohit Jain <Rohit.Jain@microsoft.com>

* Fix Surface String to Token Mappings for Case Encoding (marian-nmt#12)

Co-authored-by: Marcin Junczys-Dowmunt <marcinjd@microsoft.com>
Co-authored-by: Rohit Jain <Rohit.Jain@microsoft.com>

* add one header file to installation

* Rename VERSION to VERSION.txt

* Rename VERSION to VERSION.txt

Installing python package fails with below error.
This change addresses this issue
```
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [10 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/home/alferre/code/sentencepiece/python/setup.py", line 111, in <module>
          version=version(),
        File "/home/alferre/code/sentencepiece/python/setup.py", line 36, in version
          with codecs.open('VERSION.txt', 'r', 'utf-8') as f:
        File "/opt/conda/envs/ptca/lib/python3.8/codecs.py", line 905, in open
          file = builtins.open(filename, mode, buffering)
      FileNotFoundError: [Errno 2] No such file or directory: 'VERSION.txt'
      [end of output]
```

---------

Co-authored-by: Rohit Jain <rjai@microsoft.com>
Co-authored-by: Rohit Jain <Rohit.Jain@microsoft.com>
Co-authored-by: Marcin Junczys-Dowmunt <marcinjd@microsoft.com>
Co-authored-by: Roman Grundkiewicz <rgrundkiewicz@gmail.com>
Co-authored-by: alexandremuzio <ax.muzio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaogao-git @emjotde @anthonyaue