chore[DST-648] upgrade tailwindcss to v4 #4407
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebald
reviewed
Feb 6, 2025
sebald
reviewed
Feb 6, 2025
| inputFocus(), | ||
| inputDisabled(), | ||
| inputError('group-error/field'), | ||
| inputHover['hover'], |
There was a problem hiding this comment.
yes. But it comes from the Input.styles.ts. The classes were build dynamically and this doesn't seems work anymore. And their solution is to "Always map props to static class names". So I changed this. Not really needed this way atm. But this was the intention before.
There was a problem hiding this comment.
But not sure what your question targets 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed when no corresponding ticket is available. Add additional informations the reviewers should know.
What should be tested?
Are they some special informations required to test something?
Reviewers:
Which persons should review this PR? Add person with @mentions
Examples:
@marigold-ui/developer
@marigold-ui/designer