[Hotfix] Adapt to New Stock Page Header DOM Structure #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d3an can you please review this PR ? |
|
Works now, thanks for the quick fix ! |
|
Works 100%. Thanks for the quick fix! |
finviz-list-index-fix
|
I'm not sure if this is relevant but just wanted to comment my findings. The fix in main_func.py did work, almost fully. I ran over 330 stock I was interest in. 329 succeeded. 1 failed. BMO. I am not seeing anything overly unique about this stock. Maybe it would have failed previously as well - I don't know. It is Bank of Montreal, and it is missing an index on finviz. I don't know if this matters, but I wanted to share just in case it was. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue where the
get_stock()function is failing due to a change in the DOM structure of the stock page header on the Finviz website. To resolve this problem, I have implemented a hotfix that adjusts the crawler's code to accommodate the updated header structure. This ensures the continued functionality of the Finviz crawler for retrieving stock data.