[Hotfix] Finviz company_details DOM fix
#204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix parsing the `company_details` due to an additional class `text-xl`
taralika
commented
Nov 23, 2023
| try: | ||
| company_details = title.cssselect('h2[class="quote-header_ticker-wrapper_company text-xl"]')[0] | ||
| except IndexError: | ||
| company_details = title.cssselect('h2[class="quote-header_ticker-wrapper_company"]')[0] |
Author
There was a problem hiding this comment.
this try except is because there are still some tickers that don't have the text-xl class on them e.g., https://finviz.com/quote.ashx?t=SQM
|
for noobs reading this to get it working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix on top of #202 to fix parsing the
company_detailsdue to an additional classtext-xl