Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missed operator #688

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fixed missed operator #688

merged 1 commit into from
Nov 20, 2024

Conversation

0-wHiTeHand-0
Copy link
Contributor

Fix for #671
Just added a missed operator.

@marius-wieschollek
Copy link
Owner

So this is in case $userId is null? If so, why not just skip the function alltogether in line 394?

@0-wHiTeHand-0
Copy link
Contributor Author

Yes, without the "?" this app causes an error in Nextcloud when saving content in a shared Office document. It seems that $userId is null sometimes and should be taken into account.
And yes, another option is just to add && (!empty($userId)) && into line 394. And the same for 393, 397, 388...

@marius-wieschollek marius-wieschollek merged commit 842af93 into marius-wieschollek:master Nov 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marius-wieschollek marius-wieschollek marius-wieschollek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0-wHiTeHand-0 @marius-wieschollek