Skip to content

Conversation

MananGandhi1810
Copy link
Contributor

Currently, ngrok runs on port 80 by default. This change points ngrok to the port where the flask process is running. For example, I run OpenAlgo Flask process on 5001 port, but when I have ngrok tunnelling turned on, the ngrok process points to port 80.

@marketcalls
Copy link
Owner

This config will impact our Ubuntu Server Side Scripts as some deploys at port 80 and port 443 based on whether SSL is enabled or not.

@MananGandhi1810
Copy link
Contributor Author

Oh, but then how can we allow the user to configure for a specific port? A new env var called NGROK_PORT?

@marketcalls
Copy link
Owner

thats a best idea. let me think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants