-
Notifications
You must be signed in to change notification settings - Fork 74
MLE-24504 Bumping all dependencies #1826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates all dependencies across the project to their latest versions to address security concerns and keep Black Duck scanning happy. The changes focus on dependency version bumps without touching Jakarta APIs.
- Updated multiple libraries including okhttp, logback, commons-lang3, and various testing dependencies
- Centralized okhttp version management by introducing a version property
- Updated copyright notice and Java version requirements in documentation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
test-app/build.gradle | Updated ml-gradle plugin, undertow, logback, and okhttp dependencies |
ml-development-tools/build.gradle | Standardized okhttp version using property |
marklogic-client-api/build.gradle | Updated multiple dependencies and copyright notice |
marklogic-client-api-functionaltests/build.gradle | Updated commons-io, okhttp, commons-lang3, and other test dependencies |
gradle.properties | Added centralized okhttp version property |
examples/build.gradle | Updated okhttp, gson, opencsv, and commons-lang3 dependencies |
CONTRIBUTING.md | Simplified Java version requirements to Java 17 only |
.copyrightconfig | Added test resources exclusion pattern |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
examples/build.gradle
Outdated
api 'org.jdom:jdom2:2.0.6.1' | ||
api 'org.dom4j:dom4j:2.1.4' | ||
api 'com.google.code.gson:gson:2.10.1' | ||
api 'com.google.code.gson:gson:2.10.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gson version (2.10.4) in examples/build.gradle differs from the version (2.13.2) in marklogic-client-api/build.gradle. Consider using a centralized version property like okhttpVersion to maintain consistency across modules.
api 'com.google.code.gson:gson:2.10.4' | |
api "com.google.code.gson:gson:${gsonVersion}" |
Copilot uses AI. Check for mistakes.
examples/build.gradle
Outdated
api "com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}" | ||
|
||
api 'org.jdom:jdom2:2.0.6.1' | ||
api 'org.dom4j:dom4j:2.1.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dom4j version (2.1.4) in examples/build.gradle differs from the version (2.2.0) in marklogic-client-api/build.gradle. Consider using a centralized version property to maintain consistency across modules.
Copilot uses AI. Check for mistakes.
Should make Black Duck happy as well. Not touching the Jakarta APIs yet, going to take care of that in a follow up PR as that needs more testing.
550ffd0
to
65fd987
Compare
Should make Black Duck happy as well.
Not touching the Jakarta APIs yet, going to take care of that in a follow up PR as that needs more testing.