Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 1, 2025

This avoids Gradle warnings and also gets the reverse proxy server tests working properly again.

@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 14:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors Gradle test task configurations to use tasks.withType(Test).configureEach pattern and properly configures custom Test tasks with required classpath and test directories. This change eliminates Gradle warnings and ensures proper functionality of reverse proxy server tests.

  • Replaced individual test task configuration with global tasks.withType(Test).configureEach pattern
  • Added missing testClassesDirs and classpath properties to custom Test tasks
  • Removed redundant useJUnitPlatform() calls from custom test tasks

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
marklogic-client-api/build.gradle Refactored test configuration to use global pattern and properly configured custom Test tasks
marklogic-client-api-functionaltests/build.gradle Moved system properties to global Test configuration and added missing classpath properties to custom tasks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

github-actions bot commented Oct 1, 2025

Copyright Validation Results
Total: 4 | Passed: 0 | Failed: 0 | Skipped: 4 | at: 2025-10-01 16:29:15 UTC | commit: 0f476c9

⏭️ Skipped (Excluded) Files

  • Jenkinsfile
  • build.gradle
  • marklogic-client-api-functionaltests/build.gradle
  • marklogic-client-api/build.gradle

✅ All files have valid copyright headers!

@rjrudin rjrudin force-pushed the feature/reverse-proxy-fix branch 2 times, most recently from acf70f2 to e070436 Compare October 1, 2025 16:19
This avoids Gradle warnings and also gets the reverse proxy server tests working properly again.

Also disabling the reverse proxy tests, as those apparently were not hitting the reverse proxy before due to a Gradle misconfiguration that this PR fixes. Opened MLE-24523 to fix those later.
@rjrudin rjrudin force-pushed the feature/reverse-proxy-fix branch from e070436 to 0f476c9 Compare October 1, 2025 16:28
@rjrudin rjrudin merged commit f1542bd into develop Oct 1, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/reverse-proxy-fix branch October 1, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant