Support PVS visibility changes for entities #1071
Annotations
7 errors and 2 warnings
ci:
pkg/demoinfocs/sendtables2/entity.go#L560
[golangci-lint] reported by reviewdog 🐶
pkg/demoinfocs/sendtables2/entity.go:560: Line contains TODO/BUG/FIXME: "todo: handle visibility" (godox)
Raw Output:
pkg/demoinfocs/sendtables2/entity.go:560: pkg/demoinfocs/sendtables2/entity.go:560: Line contains TODO/BUG/FIXME: "todo: handle visibility" (godox)
// todo: handle visibility
|
ci:
pkg/demoinfocs/sendtables2/entity.go#L455
[golangci-lint] reported by reviewdog 🐶
var-naming: don't use underscores in Go names; func parameter has_vis_bits should be hasVisBits (revive)
Raw Output:
pkg/demoinfocs/sendtables2/entity.go:455:38: var-naming: don't use underscores in Go names; func parameter has_vis_bits should be hasVisBits (revive)
func readEntityUpdateType(r *reader, has_vis_bits uint32) (updateType, uint32) {
^
|
ci:
pkg/demoinfocs/sendtables2/entity.go#L460
[golangci-lint] reported by reviewdog 🐶
if statements should only be cuddled with assignments (wsl)
Raw Output:
pkg/demoinfocs/sendtables2/entity.go:460:2: if statements should only be cuddled with assignments (wsl)
if flags&0x02 != 0 {
^
|
ci:
pkg/demoinfocs/sendtables2/entity.go#L463
[golangci-lint] reported by reviewdog 🐶
if statements should only be cuddled with assignments (wsl)
Raw Output:
pkg/demoinfocs/sendtables2/entity.go:463:2: if statements should only be cuddled with assignments (wsl)
if has_vis_bits != 0 {
^
|
ci:
pkg/demoinfocs/sendtables2/entity.go#L469
[golangci-lint] reported by reviewdog 🐶
return statements should not be cuddled if block has more than two lines (wsl)
Raw Output:
pkg/demoinfocs/sendtables2/entity.go:469:2: return statements should not be cuddled if block has more than two lines (wsl)
return updateTypeDelta, flags
^
|
ci:
pkg/demoinfocs/sendtables2/entity.go#L553
[golangci-lint] reported by reviewdog 🐶
if statements should only be cuddled with assignments used in the if statement itself (wsl)
Raw Output:
pkg/demoinfocs/sendtables2/entity.go:553:4: if statements should only be cuddled with assignments used in the if statement itself (wsl)
if !e.active {
^
|
ci
Process completed with exit code 1.
|
ci
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v2, actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
ci
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|