fix: retrieve and update correct player after disconnection/bot take over #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…over Use the current m_hController value to retrieve the player and move the logic out of m_hController updates.
akiver
force-pushed
the
fix-player-bot-disconnect
branch
from
1d6fc03 to
d34da65
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 80.36% 80.39% +0.03%
==========================================
Files 47 47
Lines 6259 6279 +20
==========================================
+ Hits 5030 5048 +18
- Misses 1019 1020 +1
- Partials 210 211 +1
☔ View full report in Codecov by Sentry. |
|
nice work! I agree this seems like a good fix for #467 |
markus-wa
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to fix #467.
This PR moves the logic inside the
OnUpdatecallback ofm_hControlleroutside to avoid calling pawn entity properties lifecycle when we should not.The pawn entity props that we need to listen now retrieve the player associated with the pawn entity from the current
m_hControllerprop value.