Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datatables cs2: update equipment owner #473

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

micvbang
Copy link
Contributor

@micvbang micvbang commented Nov 14, 2023

This relates to #472.
This PR sets an equipment's owner to nil in cases where the equipment is destroyed or dropped, making GameState().Weapons() give a slightly more correct view of a player's weapons.

Note: in my experience it still shows duplicate knives and starter pistols.

EDIT: I wonder if the duplicate starter weapons are due to player deaths? 🤔

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f88e6d5) 80.50% compared to head (a4106dc) 80.40%.
Report is 1 commits behind head on master.

❗ Current head a4106dc differs from pull request most recent head e3feeed. Consider uploading reports for the commit e3feeed to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   80.50%   80.40%   -0.11%     
==========================================
  Files          47       47              
  Lines        6290     6281       -9     
==========================================
- Hits         5064     5050      -14     
- Misses       1017     1020       +3     
- Partials      209      211       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markus-wa markus-wa enabled auto-merge November 16, 2023 15:19
@markus-wa markus-wa merged commit 94ad2da into markus-wa:master Nov 16, 2023
@micvbang micvbang deleted the micvbang/weapon-owner branch November 16, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants