fix: stable sort messages #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #555
All messages (SVC/UserMessages/GameEvents etc.) found in a demo packet are sorted based on their priority (ported from dotabuff/manta). The used sorting function
sort.Slice()performs an unstable sort which might cause messages of the same priority to be reordered in arbitrary order. This PR changes sorting function tosort.SliceStable().This unstable sort behaviour breaks POV demos while not affecting normal demos for some reason - someone can investigate further.
I tested it on broken POV demo that was provided with issue and 9 more that I had available - they all correctly parsed after this change.