Add domain argument, do some error checking of the arguments and extend usage info.#31
Open
TomSievers wants to merge 2 commits intomarkusj:masterfrom
Open
Add domain argument, do some error checking of the arguments and extend usage info.#31TomSievers wants to merge 2 commits intomarkusj:masterfrom
TomSievers wants to merge 2 commits intomarkusj:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some hardware the device is not necessarily located in PCI domain 0 (for example raspberry pi 5). To allow uploading the firmware on these platforms I added a domain option, it defaults to 0 but if it needs to be changed there is an argument to do so.
Also while I was making changes I extend the information printed by the usage function.
Next to the new argument I also added some argument verification after parsing to ensure proper operation before anything is done.