Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, details about rooms and their data structures live inside the Scaper object including some adhoc handling of directory structures. Moving this out should make it easier to implement things like virtual rooms in the API.
Changes:
SOFARoomclassSOFARoom.get_ambient_noise_pathsformerlyScaper.use_room_ambient_noisefoa_experimentsSOFARoom.get_irsformerlyScaper.get_room_irs_wav_xyzSOFARoom._format_irsformerlyScaper.get_format_irs(disableformat=False)SOFARoom.get_positionsformerlyScaper.get_room_irs_xyzSOFARoom.get_boundariesformerlyScaper._get_room_min_maxBaseRoomadded as a generic base class. May just change toRoom?ScaperScaper.room: SOFARoomrir_dir, room:str, formatare now underSOFARoomuse_room_ambient_noise=Truemoved fromScaper.__init__toScaper.add_backgroundThis is just a sketch, so feel free to discuss alterations. This PR should all be structural so the audio outputs should stay exactly the same.
I have generated some test files successfully, but my FSD50K download is only partial right now (for some reason).