Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.10-3.12 and drop EOL 3.5-3.7 #161

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 5, 2024

Also modernise the GitHub Actions workflows and upgrade Python syntax with https://github.com/asottile/pyupgrade --py38-plus.

3.12 will fail until #160 is merged; I can remove it from this PR if you want to merge this first.

@lostanlen
Copy link
Member

Hello @hugovk, thank you for this. Indeed I was having issues with launching the GitHub action for your earlier PR

@coveralls
Copy link

Coverage Status

coverage: 98.823%. remained the same
when pulling e66831d on hugovk:update-ci
into 0a428b8 on rabitt:master.

@lostanlen
Copy link
Member

@hugovk sorry for the naive request but i can't seem to be able to merge this. Here's what i'm seeing:

Screenshot 2024-01-05 at 15 23 12

Is there a way i can bypass this "required" build of python 3.5?

Thanks

@hugovk
Copy link
Contributor Author

hugovk commented Jan 5, 2024

Not a naive question at all! Do you have admin access to this repo?

If so, have a look at https://github.com/rabbit/pysox/settings/branches and there'll be a branch protection rule.

You can edit it and remove the rules for the old ones, and optionally add the new ones.

@lostanlen
Copy link
Member

Thanks @hugovk. Looks like i'm maintainer but not admin. I have notified the admin, Rachel Bitner, over email. Will report back soon

@lostanlen
Copy link
Member

Hello @hugovk, I am now able to merge this thanks to @rabitt

@lostanlen lostanlen merged commit 5e93526 into marl:master Jan 23, 2024
5 of 6 checks passed
@lostanlen lostanlen mentioned this pull request Jan 23, 2024
@hugovk hugovk deleted the update-ci branch January 23, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants