Fix creating a contact without company fails with FakeRest

marmelab · Sep 12, 2024 · e8196ee · e8196ee
1 parent 887caa1
commit e8196ee
Showing 1 changed file with 14 additions and 18 deletions.
diff --git a/src/providers/fakerest/dataProvider.ts b/src/providers/fakerest/dataProvider.ts
@@ -351,9 +351,11 @@ export const dataProvider = withLifecycleCallbacks(
                 return fetchAndUpdateCompanyData(newParams, dataProvider);
             },
             afterCreate: async result => {
-                await updateCompany(result.data.company_id, company => ({
-                    nb_contacts: (company.nb_contacts ?? 0) + 1,
-                }));
+                if (result.data.company_id != null) {
+                    await updateCompany(result.data.company_id, company => ({
+                        nb_contacts: (company.nb_contacts ?? 0) + 1,
+                    }));
+                }
 
                 return result;
             },
@@ -362,9 +364,11 @@ export const dataProvider = withLifecycleCallbacks(
                 return fetchAndUpdateCompanyData(newParams, dataProvider);
             },
             afterDelete: async result => {
-                await updateCompany(result.data.company_id, company => ({
-                    nb_contacts: (company.nb_contacts ?? 1) - 1,
-                }));
+                if (result.data.company_id != null) {
+                    await updateCompany(result.data.company_id, company => ({
+                        nb_contacts: (company.nb_contacts ?? 1) - 1,
+                    }));
+                }
 
                 return result;
             },
@@ -376,9 +380,7 @@ export const dataProvider = withLifecycleCallbacks(
                 const { contact_id } = result.data;
                 const { data: contact } = await dataProvider.getOne(
                     'contacts',
-                    {
-                        id: contact_id,
-                    }
+                    { id: contact_id }
                 );
                 await dataProvider.update('contacts', {
                     id: contact_id,
@@ -405,9 +407,7 @@ export const dataProvider = withLifecycleCallbacks(
                 const { contact_id } = result.data;
                 const { data: contact } = await dataProvider.getOne(
                     'contacts',
-                    {
-                        id: contact_id,
-                    }
+                    { id: contact_id }
                 );
                 if (taskUpdateType !== TASK_DONE_NOT_CHANGED) {
                     await dataProvider.update('contacts', {
@@ -428,9 +428,7 @@ export const dataProvider = withLifecycleCallbacks(
                 const { contact_id } = result.data;
                 const { data: contact } = await dataProvider.getOne(
                     'contacts',
-                    {
-                        id: contact_id,
-                    }
+                    { id: contact_id }
                 );
                 await dataProvider.update('contacts', {
                     id: contact_id,
@@ -473,9 +471,7 @@ export const dataProvider = withLifecycleCallbacks(
                 const contactIds = contacts.map(contact => contact.id);
                 await dataProvider.updateMany('contacts', {
                     ids: contactIds,
-                    data: {
-                        company_name: name,
-                    },
+                    data: { company_name: name },
                 });
                 return result;
             },