-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(auth): Handle resetPassword and Invite user #43
Conversation
Co-authored-by: Jonathan <125876152+jonathan-marmelab@users.noreply.github.com>
package.json
Outdated
@@ -19,7 +19,7 @@ | |||
"papaparse": "^5.4.1", | |||
"prop-types": "^15.8.1", | |||
"ra-data-fakerest": "^5.1.1", | |||
"ra-supabase": "^3.0.0", | |||
"ra-supabase": "^3.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: there is no 3.0.1. You should require a 3.1.0 instead.
"ra-supabase": "^3.0.1", | |
"ra-supabase": "^3.1.0", |
@@ -71,7 +71,7 @@ enabled = true | |||
# in emails. | |||
site_url = "http://localhost:5173/" | |||
# A list of *exact* URLs that auth providers are permitted to redirect to post authentication. | |||
additional_redirect_urls = ["https://localhost:5173/auth-callback/index.html"] | |||
additional_redirect_urls = ["https://localhost:5173/auth-callback.html"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you need to update the documentation following this change?
You've been invited to join the (Name) organization. Confirm | ||
your address below: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This too looks like something that we should document (replacing the organization name in the template)
Also, I think I found a small bug. EDIT: You can probably ignore this: I seems this bug has been identified and fixed in #45 |
Problem
As a new user, I want to know when I'm invited to join the CRM and configure my own password
Solution
Implement setPassword and Invite user via Supabase. Handle in HashRouter
How to test
Reset
Invite user