Feat(auth): Handle resetPassword and Invite user #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-marmelab
approved these changes
Aug 8, 2024
Co-authored-by: Jonathan <125876152+jonathan-marmelab@users.noreply.github.com>
slax57
reviewed
Aug 8, 2024
package.json
Outdated
| @@ -19,7 +19,7 @@ | |||
| "papaparse": "^5.4.1", | |||
| "prop-types": "^15.8.1", | |||
| "ra-data-fakerest": "^5.1.1", | |||
| "ra-supabase": "^3.0.0", | |||
| "ra-supabase": "^3.0.1", | |||
There was a problem hiding this comment.
nitpick: there is no 3.0.1. You should require a 3.1.0 instead.
Suggested change
| "ra-supabase": "^3.0.1", | |
| "ra-supabase": "^3.1.0", |
| @@ -71,7 +71,7 @@ enabled = true | |||
| # in emails. | |||
| site_url = "http://localhost:5173/" | |||
| # A list of *exact* URLs that auth providers are permitted to redirect to post authentication. | |||
| additional_redirect_urls = ["https://localhost:5173/auth-callback/index.html"] | |||
| additional_redirect_urls = ["https://localhost:5173/auth-callback.html"] | |||
There was a problem hiding this comment.
don't you need to update the documentation following this change?
Comment on lines
+63
to
+64
| You've been invited to join the (Name) organization. Confirm | ||
| your address below: |
There was a problem hiding this comment.
This too looks like something that we should document (replacing the organization name in the template)
slax57
reviewed
Aug 8, 2024
|
Also, I think I found a small bug. EDIT: You can probably ignore this: I seems this bug has been identified and fixed in #45 |
jonathan-marmelab
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As a new user, I want to know when I'm invited to join the CRM and configure my own password
Solution
Implement setPassword and Invite user via Supabase. Handle in HashRouter
How to test
Reset
Invite user