Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mail): Support recipient with empty Name #52

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

slax57
Copy link
Collaborator

@slax57 slax57 commented Aug 9, 2024

Problem

When sending an email to an address that has no first and last name, it creates a contact with no first and last name.

Solution

We should use the part of the email before the @ and split it between dots to fill the first and last name.

How To Test

Send a message to an email not in your contacts.

Alternatively, this can be tested locally using the sample curl command here and clearing the To.Name field.

@slax57 slax57 added the RFR label Aug 9, 2024
@jonathan-marmelab jonathan-marmelab merged commit 4576300 into main Aug 9, 2024
5 checks passed
@jonathan-marmelab jonathan-marmelab deleted the feat/email-support-empty-name branch August 9, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants