Feat(inbound): Bind company name from domain #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
requested changes
Aug 12, 2024
| }); | ||
| }; | ||
|
|
||
| export function extractCompanyName(domain: string) { | ||
| const name = domain.split('.').at(-2)!; |
There was a problem hiding this comment.
This won't work for second level domains, e.g. .co.uk. IMO the best thing to do is rely on a third-party lib to strip those from the domain...
jonathan-marmelab
changed the title
|
Setting up a library leads to problems with unit tests due to the incompatibility with node and Deno. We will need to invest on this to set up everything correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
How To Test
Additional Checks
Tested with fakerest provider (see related documentation)(N/A)