Fix useDataProvider should only log errors in development mode
#10515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
approved these changes
Feb 16, 2025
|
A unit test fails... |
|
Any updates? |
hey, I was quite busy last week. I will update tests today |
slax57
requested changes
Feb 24, 2025
| @@ -229,7 +229,8 @@ describe('useDataProvider', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it('should call getList and show error', async () => { | |||
| it('should call getList and show error in development environment', async () => { | |||
| process.env.NODE_ENV = 'development'; | |||
There was a problem hiding this comment.
I'm afraid mutating process.env.NODE_ENV like that will leak to other tests and break test independence. Can you mock the result using jest.mock or jest.spy instead (and call jest.restoreMocks at the end)?
There was a problem hiding this comment.
hey 👋
I updated the tests in a slightly different manner than you suggested 🤞. If that's not suitable, I can implement the approach you recommended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8738