Add a tips section on the home page #10541
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilbill
reviewed
Feb 24, 2025
docs/js/ra-doc-exec.js
Outdated
| } else { | ||
| // fetch the new content | ||
| fetch(window.location.pathname) | ||
| .then(res => res.text()) | ||
| .then(replaceContent) | ||
| .then(() => { | ||
| toggleDockBlocks(false); |
There was a problem hiding this comment.
I know it's not from your PR but this typo trigger me...
- toggleDockBlocks(false);
+ toggleDocBlocks(false);
guilbill
requested changes
Feb 24, 2025
There was a problem hiding this comment.
Thanks for the fix on the navigation and the simplification with the modules 👍🏻
Regarding the tips section, I'm a bit annoyed by the flickering introduced with this part...
Screencast from 2025-02-24 14-51-12.webm
I don't know what is the best solution but I think we can do better, let's discuss that with the rest of the team to find some ideas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have many tips that we regularly post on different medias. It's a shame we don't use them on the documentation itself
Solution
How To Test
make docAdditional Checks
masterfor a bugfix, ornextfor a featureAlso, please make sure to read the contributing guidelines.