Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our packages exports are wrong, making them unusable in Node contexts (for instance when using SSR or RSC frameworks)
Solution
.jsextensions to ourlodashimports as it causes issues in ESM setupHow To Test
make buildnpm packin each package you'll want to use in the tests explained below. You'll have to move/copy them in avendordirectory and provide their path in your test applicationpackage.json.ra-core,ra-data-fakerest,ra-i18n-polyglot,ra-language-englishanddata-generator-retailESM
shadcn-admin-kitvendordirectory:{ "data-generator-retail": "./vendor/data-generator-retail-5.12.0.tgz", "ra-core": "./vendor/ra-core-5.12.0.tgz", "ra-data-fakerest": "./vendor/ra-data-fakerest-5.12.0.tgz", "ra-i18n-polyglot": "./vendor/ra-i18n-polyglot-5.12.0.tgz", "ra-language-english": "./vendor/ra-language-english-5.12.0.tgz", }/adminroute:CJS
node-testdirectorydata-generator-retailfrom thevendordirectory as explained before{ "data-generator-retail": "./vendor/data-generator-retail-5.12.0.tgz", }index.cjs(note the .cjs extension) file with the following content:node ./index.cjsAdditional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature