migrate deprecated <ListItemSecondaryAction />
#11033
Open
+84
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smeng9
commented
Nov 11, 2025
Contributor
Author
smeng9
left a comment
smeng9
left a comment
There was a problem hiding this comment.
remove unused import
djhi
reviewed
Nov 12, 2025
slax57
requested changes
Nov 20, 2025
slax57
requested changes
Nov 21, 2025
Contributor
slax57
left a comment
slax57
left a comment
There was a problem hiding this comment.
Otherwise I prefer this version. Thanks for taking my feedback into account!
Comment on lines
+176
to
+192
| <StyledListItem | ||
| disablePadding | ||
| secondaryAction={ | ||
| isSelected ? ( | ||
| <IconButton | ||
| size="small" | ||
| onClick={event => { | ||
| event.stopPropagation(); | ||
| handleClick(); | ||
| }} | ||
| > | ||
| <CancelIcon /> | ||
| </IconButton> | ||
| ) : null | ||
| } | ||
| {...rest} | ||
| > |
Contributor
There was a problem hiding this comment.
This causes a minor visual difference:
BEFORE
AFTER
Story: http://localhost:9010/?path=/story/ra-ui-materialui-list-filter-filterlist--basic
Comment on lines
+71
to
+82
| <StyledListItem | ||
| className={className} | ||
| sx={sx} | ||
| disablePadding | ||
| secondaryAction={ | ||
| isSelected ? ( | ||
| <IconButton size="small" onClick={toggleFilter}> | ||
| <CancelIcon /> | ||
| </IconButton> | ||
| ) : null | ||
| } | ||
| > |
Contributor
There was a problem hiding this comment.
Same here. This is more visible here because it creates a misalignment with the button to remove the save query:
BEFORE
AFTER
Story: http://localhost:9010/?path=/story/ra-ui-materialui-list-filter-savedquerieslist--basic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUI deprecates ListItemSecondaryAction component https://mui.com/material-ui/migration/migrating-from-deprecated-apis/ since v6
secondaryAction as a prop is still supported in MUI v5 through v7 https://v5.mui.com/material-ui/api/list-item/#list-item-prop-secondaryAction
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature