Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ghrc container #581

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

ankudinov
Copy link

Start building marp-cli container on GHRC.
Fixes #578

@ankudinov
Copy link
Author

The workflow is currently hardcoded to build on my branch to test before merging.
Do not move out of draft status before changing that.

@ankudinov
Copy link
Author

@yhatt I'd appreciate some help explaining the current Dockerfile logic. Unfortunately I have 0 skills in Node and it can be something trivial.
However my build is using existing Dockerfile and fails with the following error:

#10 25.06 Error: Cannot find module './lib/marp-cli.js'

This probably comes from marp-cli.js:

require('./lib/marp-cli.js')

I can not get how this file supposed to be created. The Dockerfile COPY --chown=marp:marp . . definitely not helping.

@ankudinov
Copy link
Author

Here is the latest build log for the reference: https://github.com/ankudinov/marp-cli/actions/runs/9383539973/job/25837379955

@yhatt
Copy link
Member

yhatt commented Jun 6, 2024

Is #515 helpful?

@yhatt
Copy link
Member

yhatt commented Jun 6, 2024

Marp team is currently using CircleCI to push the image to Docker Hub. The triggers and build steps are following:

  • When updated main branch:
    1. CI will run the test for every supported Node.js versions.
    2. If all tests passed, CI will build Marp CLI with the build command yarn build. At this time, necessary files will be generated in the lib directory.
    3. After building, CI will restore previously stored artifacts, build the multi-arch image linux/amd64 and linux/arm64 (for Apple Silicon), and publish it to the Docker Hub with latest tag.
  • When pushed the tag starting with v.:
    1. CI will build Marp CLI and generate the lib directory.
    2. After building, CI will build and publish the image tagged with the version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish the Docker image to GitHub container registry
2 participants